Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving recursive serde into the decorator #5973

Merged

Conversation

tudorcebere
Copy link
Collaborator

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@madhavajay madhavajay self-requested a review September 15, 2021 23:16
Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. I merged with dev and fixed the circular import in RecursiveSerde.

@madhavajay
Copy link
Collaborator

madhavajay commented Sep 16, 2021

Added a hot fix to disable pydp in CI to fix broken CI.
OpenMined/PyDP#393

@madhavajay madhavajay merged commit 0521f40 into OpenMined:dev Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants